-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples/placeholder to supports an interactive websocke… #24652
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:Placeholder_AddWebSocketInteractiveMode
Jan 26, 2023
Merged
Update examples/placeholder to supports an interactive websocke… #24652
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:Placeholder_AddWebSocketInteractiveMode
Jan 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
Jan 25, 2023
PR #24652: Size comparison from 583e976 to 7572117 Increases (7 builds for bl702, cc13x2_26x2, esp32, telink)
Decreases (7 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
changed the title
[WIP] Update examples/placeholder to supports an interactive websocke…
Update examples/placeholder to supports an interactive websocke…
Jan 26, 2023
vivien-apple
force-pushed
the
Placeholder_AddWebSocketInteractiveMode
branch
from
January 26, 2023 08:02
7572117
to
a0eb8c3
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 26, 2023 08:02
pullapprove
bot
requested review from
mlepage-google,
msandstedt,
pjzander-signify,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
xylophone21,
yufengwangca and
yunhanw-google
January 26, 2023 08:03
PR #24652: Size comparison from 2ce5f2d to a0eb8c3 Increases (4 builds for cyw30739, nrfconnect, psoc6, telink)
Decreases (5 builds for bl602, esp32, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t mode
Problem
The
examples/placeholder/apps
does useyaml
tests but does not supports an interactive server mode, similar to the underlying work that is happening forchip-tool
.This PR adds supports for it.